docs(cb-a11y): add accessibility (a11y) cookbook #1625
Conversation
| Similarly, we need to provide quick in-page links to help users who rely on assistive | ||
| technology to navigate our page. | ||
|
|
||
| These are called `skiplinks` and remain completely hidden until focused through `keyboard navigation`. |
There was a problem hiding this comment.
I'm noting this here but it's more of a general question - are the code backticks appropriate for calling out technical terms or should some of these really be ems?
There was a problem hiding this comment.
These do provide a particular emphasis highlight that is used a lot inside the docs.
There was a problem hiding this comment.
Right, but typically the code backticks are for actual snippets of code or commands - variable names, hex values, CLI commands, that sort of thing. Whereas technical terms get the em treatment.
There was a problem hiding this comment.
Agreed. However that is more an A2 doc wide discussion so will align this one to the styles of the other docs for now.
Foxandxss
changed the title
AlmeroSteyn
force-pushed
the
cb-a11y-dt
branch
3 times, most recently
from
99d1ced to
8b74462
Compare
AlmeroSteyn
force-pushed
the
cb-a11y-dt
branch
2 times, most recently
from
f484de2 to
603a407
Compare
|
@AlmeroSteyn - e2e tests are failing because the ts compiler is reporting errors. Can you investigate and fix the issues? |
|
All: @AlmeroSteyn isn't currently available. As agreed discussed with @wardbell via slack: @Foxandxss or @filipesilva could you look into upgrading the code from use of ng beta/rc to 2.1.x? |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
I authored the most recent commit. I'm replying to confirm. |
|
What do we need to do to get this up to date and merged? |
READY FOR REVIEW
Current and up to date PR for the a11y cookbook.
Also contains copy-edits from @naomiblack from #1181 .
Both #1049 and #1181 are now outdated in terms of content and should be closed, but conserved for comments therein.