Skip to content

fix(auth): use onAuthStateChanged for authState#2308

Merged
jamesdaniels merged 1 commit intoangular:v5from
sarunint:patch-1
Feb 5, 2020
Merged

fix(auth): use onAuthStateChanged for authState#2308
jamesdaniels merged 1 commit intoangular:v5from
sarunint:patch-1

Conversation

@sarunint
Copy link
Contributor

@sarunint sarunint commented Feb 3, 2020

Checklist

Description

This fixes #2307 where AngularFireAuth.authState incorrectly uses auth.onIdTokenChanged.

Code sample

None

@sarunint sarunint closed this Feb 3, 2020
@sarunint sarunint reopened this Feb 3, 2020
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jamesdaniels jamesdaniels merged commit 9506f85 into angular:v5 Feb 5, 2020
@jamesdaniels
Copy link
Member

I'll cut 5.4.1 shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants