fix(material/chips): chips form control updating value immediately #30818
+85
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when we have chips with form control, the value is updated only when its focused out. This fix will update the value of form control immediately Fixes angular#28065
mistrykaran91
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
|
@mmalerba , I have raised a new PR here. The old one seems to be messed up while rebasing. Also, I have added here the extra check for |
mmalerba
approved these changes
Apr 14, 2025
|
CARETAKER NOTE: There are still 18 projects with failing tests. I think they're most likely just bad tests, where people expected the current behavior because it was the current behavior, rather than because it actually makes sense. But we will need to go through and fix those before we can land this |
mmalerba
added
the
merge: caretaker note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we have chips with form control, the value is updated only when its focused out. This fix will update the value of form control immediately
Fixes #28065