fix(cdk-experimental/scrolling): Fix ExpressionChangedAfterItWasCheckedError #31076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When components use `OnPush`, they prevent `ExpressionHasChanged...` from being thrown when it should (angular/angular#45612). The exhaustive option ignores dirty flags and traverses the entire view tree checking for changes. This commit configures component tests to do this by default and opts out any tests with existing issues.
…edError This fixes an expressionchanged... error in the scrolling where template updates were not accompanied by a change notification (`markforCheck`/signal update, etc).
atscott
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
crisbeto
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an expressionchanged... error in the scrolling where template updates
were not accompanied by a change notification (
markforCheck/signalupdate, etc).
First commit is #31069