fix(ng-dev): prioritize retrieving github tokens from gh cli instead of environment #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of environment Set up retrieving github tokens for ng-dev commands using the gh cli auth rather than from the environment variable. Additionally, we set a warning indicating environment variable auth tokens are going away.
devversion
reviewed
Nov 14, 2025
| try { | ||
| /** Silent mode is used to prevent the token lookup from being printed into the logs. */ | ||
| const mode = 'silent'; | ||
| const ghCliToken = ChildProcess.spawnSync('gh', ['auth', 'token'], {mode}).stdout.trim(); |
Member
There was a problem hiding this comment.
Do we need to be careful with logging? IIIRC the helper logs output raw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up retrieving github tokens for ng-dev commands using the gh cli auth rather than from the environment variable. Additionally, we set a warning indicating environment variable auth tokens are going away.