refactor: revert at link support but expose an API for post-processing system prompts #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g prompts * We find the at-link support to be non-ideal given requirements inside Google, or differences by different agents— so we revert it. We don't expect any usages as it was just available for a very short time (less than 2 hours) * We will expose a hook for advanced executors to post-process system prompts. We can evolve that API as we detect more need.
devversion
commented
Oct 23, 2025
| * @param isEditing Whether this is an editing or generation step. | ||
| */ | ||
| private getStepPromptDefinition( | ||
| private async getStepPromptDefinition( |
Member
Author
There was a problem hiding this comment.
Note: As I initially did also run the hook against executable prompts, these changes are still here. I think we should keep them as this is helpful for when we support DevX with custom metadata that may be attached to executable prompts.
(Notably the async logic isn't super optimized here— there might be gaps for more parallelization— but we can always improve that as we go)
mturco
approved these changes
Oct 23, 2025
crisbeto
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We find the at-link support to be non-ideal given requirements inside Google, or differences by different agents— so we revert it. We don't expect any usages as it was just available for a very short time (less than 2 hours)
We will expose a hook for advanced executors to post-process system prompts. We can evolve that API as we detect more need.