Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tour in Rmd #185

Merged
merged 6 commits into from
Jan 26, 2025
Merged

fix tour in Rmd #185

merged 6 commits into from
Jan 26, 2025

Conversation

tdhock
Copy link
Collaborator

@tdhock tdhock commented Jan 26, 2025

Closes #183

when running new test locally, the failure I get is:

── Failure: clicking bottom plot keeps driver open ─────────────────────────────
`djs.start1.bottom.list` not identical to `expected.driver.bottom`.
Component “title”: names for current but not for target
Component “title”: Length mismatch: comparison on first 0 components
Component “description”: names for current but not for target
Component “description”: Length mismatch: comparison on first 0 components

Error:
! Test failed
Backtrace:
    ▆
 1. ├─testthat::test_that(...)
 2. │ └─withr (local) `<fn>`()
 3. └─reporter$stop_if_needed()
 4.   └─rlang::abort("Test failed", call = NULL)

@tdhock
Copy link
Collaborator Author

tdhock commented Jan 26, 2025

testing selectors in firefox inspect console

document.querySelector("#plot1bottom_q")
<svg id="plot1bottom_q" height="400" width="400">

document.querySelector("#plot1bottom_q .geom1_point_q")
<g class="geom1_point_q">

@tdhock
Copy link
Collaborator Author

tdhock commented Jan 26, 2025

GitHub actions test result:

[ FAIL 2 | WARN 0 | SKIP 0 | PASS 1148 ]

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-renderer1-knit-print.R:234:3'): clicking bottom plot keeps driver open ──
`djs.start1.bottom.list` not identical to `expected.driver.bottom`.
Component “title”: names for current but not for target
Component “title”: Length mismatch: comparison on first 0 components
Component “description”: names for current but not for target
Component “description”: Length mismatch: comparison on first 0 components
── Failure ('test-renderer2-param-off.R:203:3'): rect default is black/transparent stroke ──
as.numeric(stroke.tab) not equal to c(1, 8).
2/2 mismatches (average diff: 1)
[1] 2 - 1 ==  1
[2] 7 - 8 == -1

[ FAIL 2 | WARN 0 | SKIP 0 | PASS [114](https://github.com/animint/animint2/actions/runs/12975903975/job/36187521713?pr=185#step:10:115)8 ]

first test failure is expected.
second is not.

@tdhock
Copy link
Collaborator Author

tdhock commented Jan 26, 2025

still getting that error in CI

[ FAIL 1 | WARN 0 | SKIP 0 | PASS 1149 ]

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-renderer2-param-off.R:203:3'): rect default is black/transparent stroke ──
as.numeric(stroke.tab) not equal to c(1, 8).
2/2 mismatches (average diff: 1)
[1] 2 - 1 ==  1
[2] 7 - 8 == -1

[ FAIL 1 | WARN 0 | SKIP 0 | PASS [114](https://github.com/animint/animint2/actions/runs/12976155070/job/36188062917?pr=185#step:10:115)9 ]

@tdhock
Copy link
Collaborator Author

tdhock commented Jan 26, 2025

we see in the CI results above that the test passes in a file named renderer3, but not renderer1 (heisenbug), so it is important to keep different renderer numbers after all!

@tdhock tdhock merged commit df025cd into master Jan 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tour starts for different animint when multiple on same page
1 participant