fix execEvenlyMinDelayMs not reflecting points/duration mutation - #364
Merged
Conversation
The setter evaluated the default at first assignment and cached it, so runtime updates to points or duration left the spacing computed from construction-time values. The docs state that options can be changed at runtime; this brings execEvenlyMinDelayMs in line with that contract. Now: if execEvenlyMinDelayMs was never explicitly set, the getter derives it from the current msDuration/points on each read. Explicit values are still honoured.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates execEvenlyMinDelayMs to be lazily derived from current points/duration unless explicitly set, and adds tests to ensure the derived value updates when inputs are mutated.
Changes:
- Make
execEvenlyMinDelayMsgetter derive frommsDuration / pointswhen no explicit value is set. - Simplify
execEvenlyMinDelayMssetter to store the provided value as-is. - Add unit tests covering re-derivation behavior when
points/durationare mutated.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/RateLimiterAbstract.test.js | Adds tests validating derived vs explicit execEvenlyMinDelayMs behavior under mutation. |
| lib/RateLimiterAbstract.js | Changes execEvenlyMinDelayMs to be computed dynamically unless explicitly set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
animir
approved these changes
Jun 5, 2026
Owner
|
@quad Hey. Looks good to me. I've added some guards for edge cases. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setter evaluated the default at first assignment and cached it, so
runtime updates to points or duration left the spacing computed from
construction-time values. The docs state that options can be changed at
runtime; this brings execEvenlyMinDelayMs in line with that contract.
Now: if execEvenlyMinDelayMs was never explicitly set, the getter
derives it from the current msDuration/points on each read. Explicit
values are still honoured.