Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create email comfirmed UI #29

Open
4 tasks
abha224 opened this issue Jun 16, 2020 · 26 comments
Open
4 tasks

Create email comfirmed UI #29

abha224 opened this issue Jun 16, 2020 · 26 comments
Assignees
@aakankshaagr
Labels
Category: User Interface Improvements or additions to design.

Comments

@abha224
Copy link
Contributor

abha224 commented Jun 16, 2020

Description

As a user, after successful registration, my email has to be confirmed. I need to see an email confirmation message in osp once verification is done.

Acceptance Criteria

Update [Required]

  • Create email confirmed UI
  • must have an appropriate message of confirmation.

Definition of Done

  • All of the required items are completed.
  • Approval by 2 mentors.

Estimation

4 hrs
@abha224 abha224 added Category: User Interface Improvements or additions to design. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jun 16, 2020
@abha224 abha224 added this to the First coding phase milestone Jun 16, 2020
@abha224 abha224 added Status: Available Issue was approved and available to claim or abandoned for over 3 days. and removed Program: GSOC Related to work completed during the Google Summer of Code Program. labels Aug 31, 2020
@abha224 abha224 removed this from the First coding phase milestone Aug 31, 2020
@m-code12
Copy link

m-code12 commented Sep 8, 2020

@abha224 Is this issue still open?

@NarimaneHennouni
Copy link

Hi, is this still open?

@emmanuelhashy
Copy link

Hi, abha224 I'd like to work on this issue.

@vj-codes
Copy link
Member

@emmanuelhashy hey are you still interested to work on this issue?

@Rahulm2310
Copy link
Contributor

@vj-codes I would like to take up this issue.

@vj-codes vj-codes mentioned this issue Jan 19, 2021
Open
4 tasks
@aakankshaagr
Copy link

@vj-codes If this issue is available I would like to work on this issue.

@emmanuelhashy
Copy link

emmanuelhashy commented Feb 2, 2021 via email

@mayburgos
Copy link

@vj-codes If this issue is available I would like to work on this issue.

You were assigned!

@emmanuelhashy
Copy link

emmanuelhashy commented Feb 9, 2021 via email

@subodhk01
Copy link

Is someone working on this issue? I would love to help

@Rahulm2310
Copy link
Contributor

@subodhk01 Thanks for showing interest but it is already been assigned to @aakankshaagr . Feel free to look through some other available issues.
@mayburgos Can you please remove the Available label as it might be confusing for a contributor. Thanks 🙂

@Aaishpra Aaishpra removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 17, 2021
@Aaishpra
Copy link
Member

@vj-codes If this issue is available I would like to work on this issue.

What are your updates @aakankshaagr are you still working on this or are you stuck somewhere do you need help? please update us in a maximum of 2 days or this issue will be made available for others

@aakankshaagr
Copy link

@Aaishpra I am still working on this issue. I am working for the first time on such issues so it's taking me longer. I am sorry for the delay. I think by this week this issue will be solved. I will surely update my progress after every 2 days.

@Aaishpra
Copy link
Member

No problem @aakankshaagr i just wanted to remind you about the issue, it's good that you are still interested in the issue and workinh on it. Let us know if you face any doubts 😉

@aakankshaagr
Copy link

@Aaishpra Earlier I forgot to ask before starting working on this issue. I saw that in swagger UI required verification and confirmation messages are present for user registration. Only email confirmation of account verification is absent. So, I have created a template for account verification successfully.
So what I have done is correct or not?
If not then can anyone help me by explaining this issue?

@Aaishpra
Copy link
Member

Aaishpra commented Feb 28, 2021 •
edited
Loading

@Aaishpra Earlier I forgot to ask before starting working on this issue. I saw that in swagger UI required verification and confirmation messages are present for user registration. Only email confirmation of account verification is absent. So, I have created a template for account verification successfully.
So what I have done is correct or not?
If not then can anyone help me by explaining this issue?

I believe it is correct as the issue mentions only about creation of UI and not about the implementation part, means a template is enough.
Can you show us the template here in the comments and everyone here can review it.

@aakankshaagr
Copy link

aakankshaagr commented Feb 28, 2021 •
edited
Loading

I believe it is correct as the issue mentions only about creation of UI and not about the implementation part, means a template is enough.
Can you show us the template here in the comments and everyone here can review it.

Yeah sure @Aaishpra.I have 2 templates in my mind.Other email templates are simple. So below one is the simple email which I thought of

image

Shall I add a tick sign or party-popper image before congratulations at center and even increase text size?

image

@Aaishpra
Copy link
Member

@aakankshaagr the project you are working for is open source programs not mentorship system.
And i think the last line should be AnitaB.org along with the link to AnitaB website instead of systers open source.
And i like the above template better.

Tagging @isabelcosta and @codesankalp so that they can also give their input here.

@Aaishpra
Copy link
Member

Aaishpra commented Feb 28, 2021 •
edited
Loading

Now i see you were confused between mentorship system and Open Source Programs since start, as you mentioned about swagger UI in one of your comment.😅

No problem though, just need a little bit tweaks here and there and everything will be fine.

@aakankshaagr
Copy link

Now i see you were confused between mentorship system and Open Source Programs since start, as you mentioned about swagger UI in one of your comment.😅

No problem though, just need a little bit tweaks here and there and everything will be fine.

Yeah I was confused between both 😅
thanks @Aaishpra , Now I got it. I will make changes as you have suggested.

@aakankshaagr
Copy link

I have made changes, as suggested by @Aaishpra.I, have attached the final drafts of both designs. @isabelcosta @Aaishpra @codesankalp Please review the designs.

Design 1 :
image

Design 2:
image
image

@codesankalp
Copy link
Member

@Aaishpra I want to ask that is this issue is related to making a web-page for email confirmed UI to display on frontend or for making an email template that needs to be sent via mail after email is Confirmed?
And the draft made by @aakankshaagr looks good but looks like email templates.

@Aaishpra
Copy link
Member

Aaishpra commented Mar 3, 2021

@codesankalp the issue description and issue heading seems very confusing now when I see it properly, for example, the issue headline suggests "Create email confirmed UI" which I think means creating an email template, but the issue description contains this line " I need to see an email confirmation message in osp once verification is done." which in my view means creating a design/UI for the webpage in OSP.
I am not sure but, @codesankalp do we have a template for the email confirmation in the project, If yes then the issue clearly means the creation of a webpage and if not then the issue suggests of creation of an email template.

Also, this issue is pretty old (open since the last GSoC period)so I am also confused with the requirements and needs for this issue.

@aakankshaagr
Copy link

I also had this doubt that @codesankalp has asked. According to the issue description, I think it will be displayed on the OSP after the account is verified. So, I think I have to create a webpage, not an email template.

@aakankshaagr
Copy link

aakankshaagr commented Mar 3, 2021 •
edited
Loading

Is this webpage okay @Aaishpra @codesankalp @isabelcosta?

image
I think I should remove "Welcome to AnitaB.Org" and in place of "To get started" ," For more information " suits better.

@codesankalp
Copy link
Member

@Aaishpra There is no email template for the email confirmation.
But if we want to send it by email then this issue must be opened in the backend Repo.
There is so much confusion in this. Why don't we ask about it to @abha224 and @isabelcosta? They can better explain this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aakankshaagr aakankshaagr

Labels
Category: User Interface Improvements or additions to design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests