fix: login and register page responsive #201
Conversation
login and register page is made responsive for all devices
|
@codesankalp please have a look at this pull request. |
| <link | ||
| rel="stylesheet" | ||
| href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" | ||
| integrity="sha384-1BmE4kWBq78iYhFldvKuhfTAU6auU8tT94WrHftjDbrCEXSU1oBoqyl2QvZ6jIW3" | ||
| crossorigin="anonymous" | ||
| /> | ||
|
|
There was a problem hiding this comment.
@pankajsahu221 Why are you adding bootstrap 5 css link here? If you want to use bootstrap 5 then install it using npm and import it in the component.
Also see my below comment related to semantic-ui, I think we don't need to use react-bootstrap here.
| Button, | ||
| } from 'semantic-ui-react'; | ||
| import { Form, Image, Divider, Icon, Message, Button } from 'semantic-ui-react'; | ||
| import { Container } from 'react-bootstrap'; |
There was a problem hiding this comment.
You have imported here { Container } from 'react-bootstrap' but react-bootstrap is not in package.json. It is not compiling locally.
Also container is present in semantic-ui: https://react.semantic-ui.com/elements/container/
There was a problem hiding this comment.
Okay, I haven't used semantic-ui, So let me see how responsive containers work in semantic-ui. @codesankalp can I use bootstrap classes to make containers responsive?
Description
Login and Register page UI is made responsive for all devices. It used to get unresponsive for tablet and mobile devices, Made both pages fully responsive.
Fixes #105
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Resize the screen size to see the responsiveness of the pages.
Checklist:
Code/Quality Assurance Only
Additional Context
I used React-bootstrap containers and their classes for the login and register page container and to make it responsive for all devices. Any suggestions are welcome.