After refreshing any tab in Requests Page, the respective tab should be displayed

[CodeChamp-SS]

Describe the bug

On refreshing through either past or all tab in the requests page, the user is redirected to the pending tab (as seen in the video), which shall not happen.

To Reproduce

Steps to reproduce the behavior:

1. Go to 'Requests page'
2. Swipe down to refresh either PAST or ALL tab
3. See the problem

Expected behavior

The same tab should be displayed after refreshing too.

Video

2021-03-07.15-02-23.mp4

[CodeChamp-SS]

I would like to take up this issue if it's approved.

[ManishPanwar556]

I would like to work on this issue @epicadk

[epicadk]

Sorry, @ManishPanwar556 it's a first-timers-only issue and you have already contributed to the repository before.

[Marvel999]

I would like to work on this issue @epicadk

[epicadk]

I would like to work on this issue @epicadk

Hi sorry, this is a first timers only issue and you have already contributed to this repository before. Please find another issue to work on.

[Marvel999]

I would like to work on this issue @epicadk

Hi sorry, this is a first timers only issue and you have already contributed to this repository before. Please find another issue to work on.

ok

[shivamparihar12]

Hi, I would like to work on this issue @epicadk

[epicadk]

Hi, I would like to work on this issue @epicadk

assigned : ).

[shivamparihar12]

I am going to be honest, after trying for 2 days I still don't know how to rectify this issue. Is there anyone who can help me?

[epicadk]

I am going to be honest, after trying for 2 days I still don't know how to rectify this issue. Is there anyone who can help me?

Have you been able to replicate it?

[shivamparihar12]

I am going to be honest, after trying for 2 days I still don't know how to rectify this issue. Is there anyone who can help me?

Have you been able to replicate it?

yes

[isabelcosta]

@shivamparihar12 Are you still interested in working on this? I don't have an idea of how to fix this, but someone in the community could have. If you're still interested do ask on Zulip or let us know what you found out so far.

Do you know what is causing the bug? Which parts of the code are causing this?

[shivamparihar12]

Yes @isabelcosta , I would love to solve this. So, I could be of some use to the community.

These screenshots are from the RequestsFragemnt.kt.

I could be wrong here but according to me this function fetchNewest() should call srlRequest.isrefreshing = false at the end

and when the user opts to refresh the viewpager2 using menu item instead of the swipe gesture. We have to set srlRequest.isrefreshing = true before calling fetchNewest()