Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug : Remove Jcenter #1127

Merged
merged 1 commit into from
May 7, 2021
Merged

Bug : Remove Jcenter #1127

merged 1 commit into from
May 7, 2021

Conversation

Marvel999
Copy link
Contributor

@Marvel999 Marvel999 commented Apr 20, 2021 •
edited
Loading

Description

Fixes #1124

Type of Change:

  • Code

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Marvel999 Marvel999 mentioned this pull request Apr 20, 2021
Closed
epicadk
epicadk approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@epicadk epicadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@epicadk epicadk added the Status: Needs Review PR needs an additional review or a maintainer's review. label Apr 20, 2021
@epicadk epicadk requested review from a team, aditmehta9, gaurivn, vj-codes and isabelcosta and removed request for a team April 20, 2021 18:50
@Marvel999
Copy link
Contributor Author

👍🏼
@epicadk can I work on this issue? #1110 Please assign me.

vj-codes
vj-codes approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marvel999 congratulations on your first contribution to the repo 🎉
Just make sure to create a new branch and then commit the changes when you are working on the next issues :)

@vj-codes vj-codes added Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Apr 20, 2021
@epicadk
Copy link
Member

epicadk commented Apr 21, 2021

@Marvel999 congratulations on your first contribution to the repo 🎉
Just make sure to create a new branch and then commit the changes when you are working on the next issues :)

Build passes. I think it can be marked as ready to merge.

@Marvel999
Copy link
Contributor Author

@Marvel999 congratulations on your first contribution to the repo 🎉
Just make sure to create a new branch and then commit the changes when you are working on the next issues :)

thank you

@vj-codes
Copy link
Member

@Marvel999 congratulations on your first contribution to the repo 🎉
Just make sure to create a new branch and then commit the changes when you are working on the next issues :)

Build passes. I think it can be marked as ready to merge.

Yes

@vj-codes vj-codes added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. labels Apr 26, 2021
isabelcosta
isabelcosta approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Marvel999 🎉

@isabelcosta isabelcosta merged commit 0e18ad3 into anitab-org:develop May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vj-codes vj-codes vj-codes approved these changes

@epicadk epicadk epicadk approved these changes

@isabelcosta isabelcosta isabelcosta approved these changes

@aditmehta9 aditmehta9 Awaiting requested review from aditmehta9

@gaurivn gaurivn Awaiting requested review from gaurivn

Assignees
No one assigned
Labels
Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug : Remove Jcenter
4 participants
@Marvel999 @epicadk @vj-codes @isabelcosta