build(deps): adopt ndk29 #496
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note, this is not ready yet, but a final commit when it is released as stable should fix it up, and it already appears to work fine
mikehardy
added
blocked on dependency
dependencies
This comment was marked as resolved.
This comment was marked as resolved.
|
Okay, this is now passing CI and just waiting for upstream to release as stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note, this is not ready yet, but a final commit when it is released as stable should fix it up, and it already appears to work fine
Just posting it because I was in there and gave it a shot and it worked, posting it up to show this is all NDK bump takes now