Set required_ruby_version and update supported OFX versions in gemspec#129
Open
marcosdemelo wants to merge 1 commit intoannacruz:mainfrom
Open
Set required_ruby_version and update supported OFX versions in gemspec#129marcosdemelo wants to merge 1 commit intoannacruz:mainfrom
marcosdemelo wants to merge 1 commit intoannacruz:mainfrom
Conversation
… gemspec Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
required_ruby_version >= 3.1.0in the gemspecsummaryanddescriptionto list all OFX versions actually supported by the parserBackground
Minimum Ruby version
The project already transitively required Ruby >= 3.1.0 via Nokogiri 1.18.x, which declares that constraint explicitly. Adding
required_ruby_versionto the gemspec makes this requirement visible upfront — it appears on the gem's page on rubygems.org and causes RubyGems to reject installation immediately with a clear message, rather than failing later during dependency resolution.Supported OFX versions
The gemspec previously advertised support only for OFX 102, 200 and 211. However,
lib/ofx/parser.rbhas been routing a wider set of versions for some time:OFX102OFX211The summary and description now reflect all seven supported versions.
Test plan