fix: setting multiple cookies in streaming mode makes an invalid set-cookie header.
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-cookie` header. For example, when using Astro Auth multiple headers can be set causing them to be concatenated with a comma. This is not a valid `Set-Cookie` header so only the first cookie is honored and the others are discarded. This causes an issue where certain auth cookies are not set eventually causing errors preventing users from logging in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, when using Astro Auth multiple headers can be set causing them to be concatenated with a comma. This is not a valid
Set-Cookieheader so only the first cookie is honored and the others are discarded.This causes an issue where certain auth cookies are not set eventually causing errors preventing users from logging in.