Propagate sendCode typescript definition from Code UI to Code Provider
#308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@thdxr could I get a review on this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to propagate the correct typescript definition, defined in CodeProviderOptions, to CodeUIOptions.
I would like to make a check during
sendCodeexecution to check if the user is registered within our system. In order to do that, I tried returningCodeProviderErrorobject fromsendCodeas defined in CodeProviderOptions, but I got a typescript error even though my implementation actually worked.Upon further investigation, it seems that the two definitions of
sendCodewithin CodeUI and CodeProvider are different.Since the
sendCodemethod is passed from CodeUI to CodeProvider, the two typescript definitions for the same method should match.An alternative to this approach, and likely better, would be to update
CodeUIOptions.sendCodedefinition to be the same asCodeProviderOptions["sendCode"]