feat(task): implement fire-and-forget TaskTool with background execution #6045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation PR1 of async subagent delegation stack (Issue anomalyco#5887). This commit introduces the SessionRunner namespace which provides a unified interface for executing session loops: - runOnce(): Synchronous execution wrapping SessionPrompt.prompt (implemented) - runBackground(): Fire-and-forget execution for async delegation (scaffold only) - Options/RunResult types for future background execution - State tracking infrastructure for active background runs No behavior change - this is purely an abstraction layer. Next: PR2 will implement runBackground() with lifecycle events.
…le events - Add Job, JobKind, JobStatus, EnqueueOptions schemas - Add enqueue(), cancel(), get(), list() APIs - Add lifecycle events (Queued, Started, Completed, Failed, Canceled, TimedOut) - Add configurable timeout and concurrency via experimental.backgroundTasks - Fix: queue now restarts after idle (removed stale started flag) - Fix: dedupe now returns completion promise, not immediate job reference
- Fix circular import by using regular function for runOnce
- Add toolPartID to Tool.Context for post-return metadata updates - Pass toolPartID from prompt.ts when invoking tool.execute - TaskTool now returns immediately after enqueueing work to SessionRunner - Subscribe to child session part updates for live progress in parent metadata - Update parent metadata with final job status on completion/failure/cancel/timeout - Handle enqueue failures with logging and proper cleanup - Use ctx.callID for accurate tool call tracing
edlsh
force-pushed
the
pr4-fire-and-forget-tasktool
branch
from
64d02c9 to
c138f7e
Compare
Contributor
Author
|
Recreating with consistent branch naming (feat/async-subagent-4-tasktool) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements Phase 4 of the Background Task Runner plan: Makes TaskTool truly fire-and-forget by returning immediately after enqueueing work to SessionRunner, while maintaining live progress updates in the parent tool part metadata.
PR Stack
feat/async-subagent-1-runnerfeat/async-subagent-2-backgroundfeat/async-subagent-3-centralizepr4-fire-and-forget-tasktoolBase: This PR is stacked on top of #6041
Changes
src/tool/tool.tstoolPartID?: stringtoTool.Contexttype for post-return metadata updatessrc/session/prompt.tstoolPartIDwhen invokingtool.execute()so tools can update their own part after returningsrc/tool/task.tsPartUpdatedevents and update parent tool part metadata viaStorage.read+Session.updatePartcompleted,failed,canceled,timed_out) when background job endsctx.callID(actual tool call ID) instead ofctx.messageIDBehavior Change
Before: TaskTool blocked until child session completed, then returned the full result.
After: TaskTool returns immediately with
"Task started in background."and the child session runs asynchronously. Progress is streamed to the parent tool part metadata. Users can click to navigate to the subagent session.Testing
Related
~/Desktop/plan.md(Phase 4)