Feat: add /review command as subagent #6967
Conversation
Make the undefined check more explicit by changing from `!item` to `item === undefined` to ensure only undefined values trigger the condition, preventing false positives from other falsy values like null, empty string, or zero.
|
The following comment was made by an LLM, it may be inaccurate: ResultsNo duplicates found. ✅ The PR "Feat add /review command as subagent" (#6967) appears to be unique. While the search found several related PRs that work with subagents, none of them are addressing the same feature:
These are all infrastructure/system improvements for existing subagents, not the addition of a new |
Githubguy132010
changed the title
|
using review agent for the review command, aren't we duplicating the review prompt on it? because we're using as the prompt for the agent + sending the same prompt as a message? |
|
That could be the case, but I don't think so, since the review command just spawns a subagent with that prompt, but I think my implementation let's the main agent just spawn the review agent exactly the same as /review does, but if I have time, I will check for verification purposes. Or could you check for me @dbpolito if needed I will update the pr to fix that.
|
Githubguy132010
force-pushed
the
feat-add-/review-command-as-subagent
branch
from
f01f3d2 to
b385759
Compare
The /review command was sending the same prompt twice - once as a user message (via subtask) and once as the system prompt (via agent definition). This change checks if the agent already has a prompt defined and only includes the template text in the user message when it doesn't.
2 participants
The main agent can now invoke the the review agent from /review as a subagent. It uses the exact same permissions and prompt as /review. Essentially, the main agent can now review its code easier.
It's important to note that this implementation will need updating to the new permission system.EDIT: Already done.
Fixes #6600