fix: allow model variants in OAuth Codex filter #7608
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Codex OAuth plugin only allowed exact model ID matches (e.g., gpt-5.2-codex). This prevented users from using custom variants defined in their opencode.json (e.g., gpt-5.2-codex-low, gpt-5.2-codex-high). The fix changes the filter to allow both base models and their variants by checking if the model ID starts with an allowed base model followed by a hyphen. Fixes anomalyco#7593 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
Yes this has turned out to be a major pain point and blocker while moving from the codex-oauth plugin to the inbuilt one in opencode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gpt-5.2-codex)gpt-5.2-codex-low,gpt-5.2-codex-high,gpt-5.2-codex-xhighare also allowedProblem
Users who defined custom reasoning effort variants in their
opencode.jsonunder theopenaiprovider found that these variants were being filtered out by the Codex plugin's OAuth loader.Solution
Changed the filter logic from exact Set matching to prefix-based matching.
Fixes #7593