fix: harden explore agent permissions and bash tool validation #7881
+46
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses security and scope concerns with the Explore agent by implementing stricter permission controls and better path validation in the Bash tool.
Changes
bash.tsto include common exploration commands likels,find,grep,cat, etc. This ensures that commands targeting external directories (e.g.,ls /) correctly trigger theexternal_directorypermission check.bashpermission for the Explore agent fromallowtoaskinagent.ts. This ensures users are prompted before the agent executes shell commands, preventing unmonitored system exploration.explore.txtto explicitly instruct the agent to stay within the project directory and warn about permission prompts for bash commands.Testing
npm run test) to ensure no regressions.