fix(router): respect path segment boundaries in route matching #6277
+139
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Route paths now only match at proper segment boundaries. Previously /travel-plan incorrectly matched /travel-plans. Changes: - Updated path matching logic to check for exact match or trailing slash - Added unit tests for path matching edge cases
Collaborator
|
thanks for the contribution @azzzy i'm trying to reproduce this with a nextjs site but i don't see the issue: 
is there an specific use case where this fails? |
Author
|
@vimtor , are you sure this isn't just Next.js client routing taking over? |
Author
|
@vimtor , I've created a minimal reproduction repo: https://github.com/azzzy/sst-routing-bug-reproduction
To reproduce: I have it deployed here - https://sst-routing-pr.sourcelab.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Router's CloudFront function uses simple
startsWith()matching for paths, causing incorrect route matching when paths share a common prefix.For example:
/travel-planincorrectly matches/travel-plans/apiincorrectly matches/api-docsSolution
Updated the path matching logic to check for proper path segment boundaries. A path now only matches if:
/, OR/Changes
CF_ROUTER_INJECTIONinplatform/src/components/aws/router.ts(line ~1541)platform/test/components/router-path-matching.test.tsTesting
The test file duplicates the path matching logic rather than importing it because the actual implementation lives inside a CloudFront function string literal. This allows testing the logic in isolation without complex string parsing.
Verified with live CloudFront deployment:
/travel-planscorrectly does NOT match route/travel-plan/travel-plan/abccorrectly matches route/travel-planBreaking Changes
None. This is a bug fix that corrects unexpected behavior.