React Native Updates #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waleedkadous
approved these changes
Feb 18, 2025
Collaborator
waleedkadous
left a comment
waleedkadous
left a comment
There was a problem hiding this comment.
Live and learn. Would never have guessed that isOpen: undefined and isOpen:false would have led to different outcomes. Did not even know a bool could be undefined.
Collaborator
Author
Yeah, I was surprised as well, undefined and false are both falsy so I would have expected them to produce the same outcome, but they didn't in this case (with React Native Modal). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR details:
Remove Flowbite and legacy UI components
This commit removes Flowbite which is a React UI library from the codebase, Flowbite isn't compatible with React Native but it isn't currently used, the library along with the components that use it have been removed.
Remove Tailwind and integrate Nativewind
Tailwind is a CSS utility framework, it isn't directly supported by React Native, this commit introduces Nativewind (which uses Tailwind internally) and brings support to RN projects while maintaining web support.
Disable automated display of the info popup
Disables the automated display of the welcome popup, it used te be displayed every single time a user logs in. The popup is still accessible via the info button.
Configure React Native Reanimated
Integrates RN Reanimated which is a foundational animation library used by numerous UI components.
Integrate React Native Drawer Layout
Replaces the existing drawer implementation with a native drawer and refactors the UI as needed.
Improve the welcome popup user experience
Adds an additional popup dismiss option to the bottom of the page and wraps the component in a safe area view.
Relocate native Capacitor projects
This commit relocates the native Capacitor projects from the root to a capacitor folder. Once we get to the React Native build, Expo CNG (Continuous Native Generation) will create two additional native projects in the same location, so I have moved the Capacitor versions to a subfolder.
Convert React SVG components to React Native SVG components
This commit converts the existing SVG web components to React Native SVG components that are compatible with both web and native versions. I have used Windsurf for this exercise, quite a powerful tool.