Refactoring #29
Merged
Refactoring #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waleedkadous
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert svg files to React Native SVG components
Raw svg files aren't directly supported by React Native, this commit migrates all raw svg files to React Native Svg following the existing structure and deletes the raw files. The only .svgs left are related to the logo.
Cleanup
Remove unused files
Refactor styles
The codebase currently uses 3 styling approaches; Nativewind, StyleSheet.create and inline styles, this commit removes the third approach (inline styles) and reverts back to standard Stylesheet.create syntax.
Optimize web build
The gesture handling framework which is required by the drawer layout component (and many other RN components) in native mode adds signifcant overhead to the web .js bundle, this commit excludes the framework from the web builds reducing bundle size by 25%.
Bundle size before:
Bundle size after:
