Add GCP Pub/Sub event source #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Dec 15, 2022
| from typing import Any, Dict | ||
|
|
||
| from google.api_core import retry | ||
| from google.cloud import pubsub_v1 |
There was a problem hiding this comment.
Does pubsub_v1 support asyncio? Typically pull-and-sleep is not the best approach.
There was a problem hiding this comment.
As far as I see this plugin would block the python thread. It could implement futures + callbacks or, I think easier, use an asyncio library compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for GCP Pub/Sub as an event source and includes an example rulebook.