Skip to content

Deprecate azure_service_bus #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Deprecate azure_service_bus #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dfa4ca
Deprecate azure_service_bus
p3ck Jul 29, 2025
6cde6bb
Merge branch 'main' into deprecate-azure_service_bus
Alex-Izquierdo Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/eda/rulebooks/github-ci-cd-rules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
- name: GitHub Deploy Git Hook Rules
hosts: all
sources:
- ansible.eda.azure_service_bus:
- azure.azcollection.azure_service_bus:
Copy link
Contributor

@ptoscano ptoscano Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct: this example correctly refers to the module shipped in this collection, so it is valid until the module is shipped in the collection.

Most likely this rulebook ought to be copied together with the non-deprecated version of azure_service_bus, and the rulebook in that location ought to refer to the new location of the EDA source.

conn_str: "{{connection_str}}"
queue_name: "{{queue_name}}"
filters:
Expand Down
3 changes: 2 additions & 1 deletion galaxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ tags:
# collection label 'namespace.name'. The value is a version range
# L(specifiers,https://python-semanticversion.readthedocs.io/en/latest/#requirement-specification). Multiple version
# range specifiers can be set and are separated by ','
dependencies: {}
dependencies:
azure.azcollection: ">=3.7.0"
Comment on lines +46 to +47
Copy link
Contributor

@ptoscano ptoscano Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this collection should start to pull other collections. Deprecating means that users should switch away from "something", while that "something" still works as-is until its removal.


# The URL of the originating SCM repository
repository: https://github.com/ansible/event-driven-ansible
Expand Down
7 changes: 7 additions & 0 deletions meta/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,10 @@ plugin_routing:
warning_text: >-
activation_info has been renamed to rulebook_activation_info.
Please update your tasks.
azure_service_bus:
redirect: azure.azcollection.azure_service_bus
deprecation:
removal_version: 3.0.0
warning_text: >-
azure_service_bus has been moved to azure.azcollection.azure_service_bus.
Please update your tasks.
Comment on lines +43 to +49
Copy link
Contributor

@ptoscano ptoscano Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work: there is no support in ansible-rulebook for deprecating/renaming/removing content as documented here:
https://docs.ansible.com/ansible/latest/dev_guide/module_lifecycle.html

Loading