-
Notifications
You must be signed in to change notification settings - Fork 131
feat: Add support for multiple Kafka brokers #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sevenup30
wants to merge
6
commits into
ansible:main
Choose a base branch
from
sevenup30:kafka_bootstrap_servers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
496ef39 to
aab0df8
Compare
aab0df8 to
fb60d42
Compare
Contributor
|
Hi @sevenup30, first of all, thanks for the PR! On the actual code:
Thanks! |
fb60d42 to
6aaa750
Compare
6aaa750 to
4e05ede
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@sevenup30 what do you think about renaming PS: I would also be interested in this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Kafka consumer configuration by adding support for connecting to multiple brokers instead of a single one.
In most non-local environments, Kafka clusters run with at least three brokers for high availability. This change allows our consumer to be aware of the entire cluster, as supported by the underlying AIOKafkaConsumer library.
Additionally, this PR introduces the client_id setting. This is a best practice for identifying and tracking the consumer's activity on the Kafka brokers, which is valuable for monitoring and debugging purposes.
Reference: AIOKafkaConsumer API Documentation