-
Notifications
You must be signed in to change notification settings - Fork 178
FIX: analyze_from_zero #6425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FIX: analyze_from_zero #6425
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6425 +/- ##
===========================================
- Coverage 81.93% 41.74% -40.20%
===========================================
Files 236 236
Lines 75770 75773 +3
===========================================
- Hits 62082 31630 -30452
- Misses 13688 44143 +30455 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anur7 see my comments.
Co-authored-by: Giulia Malinverno <[email protected]>
# Conflicts: # tests/system/general/test_27_Maxwell2D.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just à minor comment
Description
This PR fixes the bug in analyze_from_zero() method in maxwell.py.
The missing unit test of the will also be added in this PR.
Issue linked
Issue #6404
Checklist