Skip to content

FEAT: 6290 Add Profile class #6478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed

Conversation

Devin-Crawford
Copy link
Contributor

Description

Add Profile class.

Issue linked

Resolve #6290

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Devin-Crawford and others added 19 commits June 18, 2025 11:53
Resolve issue 6278. Allow a list to be passed
for the "Frequency" argument and automatically apply the multi-frequency adapt setup.
- Profile
- Variation
Use the project name to save the new project after it is extracted from an archive.
Create a Profiles class, call it from setup.get_profile(). The actual profile for a single simulation is an instance of SimulationProfile.
Basic class is working.
- When an archive file is extracted, the
  project file stem name will be incremented
  by an integer if the project file already
  exists.
…rofile_class

# Conflicts:
#	src/ansys/aedt/core/application/design.py
- Simplify syntax.
…oject' into fix/6400-use-archive-name-for-project
…rofile_class

# Conflicts:
#	src/ansys/aedt/core/application/design.py
- Simplify syntax.
- Simplify syntax.
- Add classes and methods to simplify handling of simulation profile data.
- Support for:
  - HFSS Adaptive passes and frequency sweep.
  - HFSS 3D Layout
  - Maxwell eddy
    - steady-state
    - transient
  - Icepak
    - transient
    - steady-state
- Fix minor bugs.
- Add pyaedt_function_handler()
- Add unit tests for Profile class.
@Devin-Crawford Devin-Crawford requested a review from a team as a code owner July 30, 2025 09:46
@Devin-Crawford Devin-Crawford marked this pull request as draft July 30, 2025 09:46
@github-actions github-actions bot added the enhancement New features or code improvements label Jul 30, 2025
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 23.59551% with 476 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.74%. Comparing base (ad6d2c9) to head (4fd1aad).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (23.59%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6478       +/-   ##
===========================================
- Coverage   77.92%   19.74%   -58.19%     
===========================================
  Files         236      237        +1     
  Lines       75731    76225      +494     
===========================================
- Hits        59017    15052    -43965     
- Misses      16714    61173    +44459     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Devin-Crawford and others added 11 commits August 9, 2025 10:53
# Conflicts:
#	src/ansys/aedt/core/application/design.py
- Check that archive file is saved and opend correctly.
- Improve support for Path
- Fix test_01_Design.py
- Fix test_01_Design.py so each unit test runs standalone.
- Make all tests independent #6523
- Deprecate Design.rename_design()
…rofile_class

# Conflicts:
#	src/ansys/aedt/core/application/design.py
#	tests/system/solvers/test_00_analyze.py
@github-actions github-actions bot added the testing Anything related to testing label Aug 13, 2025
@Devin-Crawford
Copy link
Contributor Author

Closing this for now and will start a new PR later. The changes to handling of archive files #6400 should be merged before the Profile is updated.

@Devin-Crawford Devin-Crawford deleted the feat/6290_profile_class branch August 13, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of solver profiles
3 participants