Skip to content

FEAT: Icepak model reviewer extension #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

siva-krishnaswamy
Copy link
Contributor

Description

** toolkit to review and modify project settings in single ui. Uses export config and import config functions in pyaedt. Exported config is displayed in a table. if modified, then imported back using import config**

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • [x ] I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • [x ] I have followed the coding style guidelines of this project.
  • [ x] I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • [x ] I have agreed with the Contributor License Agreement (CLA).

@siva-krishnaswamy siva-krishnaswamy requested a review from a team as a code owner August 6, 2025 08:22
@github-actions github-actions bot added the enhancement New features or code improvements label Aug 6, 2025
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 0% with 543 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.72%. Comparing base (ce0cb3b) to head (fc1e25d).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6495      +/-   ##
==========================================
+ Coverage   81.44%   81.72%   +0.28%     
==========================================
  Files         230      234       +4     
  Lines       73726    74753    +1027     
==========================================
+ Hits        60044    61092    +1048     
+ Misses      13682    13661      -21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys
Copy link
Member

Hi @siva-krishnaswamy @lorenzovecchietti ,

I think you missed the last update regarding extensions, we are in the middle of the refactoring of the extension to follow a common way, so we need you to refactor it in a proper way. Here you can find some guidelines:

https://aedt.docs.pyansys.com/version/stable/Getting_started/Contributing.html#extension-development-guide

And as you can see, it is an ongoing process, some extensions are migrated and others are not:
#6228

In summary, we are improving:

  1. Using the Common Extension Class to unify extension implementation.
  2. Testing the UI, now we are also adding the test of every action inside the UI.
  3. Improve documentation if possible.

Please reach out if you have comments.

@Samuelopez-ansys
Copy link
Member

@siva-krishnaswamy @lorenzovecchietti My previous message is not 100% correct, I see you are using the Common class, GREAT!

You just missed the unit tests, please check that we have system tests and unit tests, the latter tests the UI interaction. I put the PR in draft to not overload the CICD until the tests are ready.

@siva-krishnaswamy
Copy link
Contributor Author

@Samuelopez-ansys , Thanks . I will add system and unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants