Skip to content

Conversation

@eblanco-ansys
Copy link
Contributor

Description

Add AssignFarFieldWave method wrapping

Issue linked

#6214

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added the enhancement New features or code improvements label Jan 5, 2026
@github-actions github-actions bot added testing Anything related to testing extensions labels Jan 5, 2026
@eblanco-ansys eblanco-ansys changed the title Wrap AssignFarFieldWave FEAT: Wrap AssignFarFieldWave Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.76%. Comparing base (f86a232) to head (63e91fa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7053      +/-   ##
==========================================
- Coverage   82.20%   80.76%   -1.45%     
==========================================
  Files         254      254              
  Lines       77319    77338      +19     
==========================================
- Hits        63562    62463    -1099     
- Misses      13757    14875    +1118     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eblanco-ansys eblanco-ansys marked this pull request as ready for review January 5, 2026 16:03
@eblanco-ansys eblanco-ansys requested a review from a team as a code owner January 5, 2026 16:03
@SMoraisAnsys
Copy link
Collaborator

Hey @eblanco-ansys, thanks for the contribution ! I'll create a new PR with the header changes before reviewing your PR. This will help to know where to review and future references to this PR

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename it to far_field_wave

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 8, 2026 20:11
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Samuelopez-ansys Samuelopez-ansys merged commit a123a1c into main Jan 8, 2026
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/far_field branch January 8, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements extensions testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants