Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

As title says
Methods related to opening, saving, and inserting files
Other various fixes to get tests running properly

Issue linked

Related to #2388

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

b-matteo and others added 11 commits December 1, 2025 16:19
… chore/v1_implementation_of_file_stub

# Conflicts:
#	src/ansys/geometry/core/_grpc/_services/v1/conversions.py
#	src/ansys/geometry/core/_grpc/_services/v1/parts.py
impl full design tessellation streaming
implementing open_file, save, and insert and routing v1 calls to them
tests that require the use of uploading garbage files are checking for errors thrown
@jacobrkerstetter jacobrkerstetter self-assigned this Dec 4, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner December 4, 2025 18:34
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 37.71930% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.23%. Comparing base (5c3c0a2) to head (ab86424).

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v1/conversions.py 16.12% 26 Missing ⚠️
src/ansys/geometry/core/modeler.py 54.16% 22 Missing ⚠️
src/ansys/geometry/core/designer/design.py 22.72% 17 Missing ⚠️
...nsys/geometry/core/_grpc/_services/v1/materials.py 0.00% 4 Missing ⚠️
...sys/geometry/core/_grpc/_services/v1/components.py 0.00% 1 Missing ⚠️
src/ansys/geometry/core/misc/options.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2443      +/-   ##
==========================================
- Coverage   91.56%   91.23%   -0.34%     
==========================================
  Files         169      169              
  Lines       11859    11919      +60     
==========================================
+ Hits        10859    10874      +15     
- Misses       1000     1045      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter mentioned this pull request Dec 4, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants