Skip to content

feat: allow deployment of custom images#2625

Merged
RobPasMue merged 4 commits intomainfrom
feat/custom-image-deployment
Mar 5, 2026
Merged

feat: allow deployment of custom images#2625
RobPasMue merged 4 commits intomainfrom
feat/custom-image-deployment

Conversation

@RobPasMue
Copy link
Member

Description

Coming from @ans-spohekar's request - being able to pass in a custom image name/tag to deploy

from ansys.geometry.core import launch_docker_modeler

# Using a custom Docker image
modeler = launch_docker_modeler(
    image="myregistry.com/my-geometry:custom-tag"
)

Make sure to pass the full image name though, not just the tag. Give it a try to this branch locally on your side if possible

@RobPasMue RobPasMue self-assigned this Mar 4, 2026
@RobPasMue RobPasMue requested a review from a team as a code owner March 4, 2026 13:45
@github-actions github-actions bot added the enhancement New features or code improvements label Mar 4, 2026
@RobPasMue
Copy link
Member Author

Let's not merge this one until it has been validated by @ans-spohekar's side

@RobPasMue RobPasMue marked this pull request as draft March 4, 2026 13:51
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.90%. Comparing base (3bdb777) to head (4e40a0c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ansys/geometry/core/connection/docker_instance.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2625      +/-   ##
==========================================
- Coverage   94.97%   94.90%   -0.07%     
==========================================
  Files         174      174              
  Lines       14488    14498      +10     
==========================================
  Hits        13760    13760              
- Misses        728      738      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue marked this pull request as ready for review March 5, 2026 08:21
@RobPasMue
Copy link
Member Author

@jacobrkerstetter - ready for review

@RobPasMue RobPasMue merged commit e6c05a0 into main Mar 5, 2026
63 checks passed
@RobPasMue RobPasMue deleted the feat/custom-image-deployment branch March 5, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants