fix: techinical review #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpchou23
approved these changes
Dec 12, 2025
Contributor
|
@jorgepiloto Do I need to create a new "core" folder under the existing "chemkin" folder? and move all the *.py files under the "chemkin" folder to this "core" folder? |
jorgepiloto
force-pushed
the
fix/project
branch
from
d5cb51f to
393db2b
Compare
Member
Author
|
Hi @cpchou23, no worries. I just adapted the code to the new layout. Once I'm done with the updates, I'll ask for a review on your side. |
try to find out why Pychemkin could not detect Ansys Chemkin installation on the linux containers.
fixed a bug related to finding the local Chemkin installation
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
cpchou23
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request is the continuation of the last technical review made to the repository. Despite many things being fixed in the first technical, the source code changed some months later. Changes include:
ansys-chemkin-coresrc/ansys/chemkin/core