-
Notifications
You must be signed in to change notification settings - Fork 16
FEAT: Reduce via by density #1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
+ Coverage 49.17% 49.55% +0.38%
==========================================
Files 255 255
Lines 38052 38110 +58
==========================================
+ Hits 18712 18887 +175
+ Misses 19340 19223 -117 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boyang2022 Please fix the codacy check.
@svandenb-dev Bo implemented both dotnet and grpc versions of the the method. I will approve now. Later on, we need to merge the two methods in a dotnet and grpc shared class.
Add reduce via by cell size