Skip to content

Conversation

boyang2022
Copy link
Collaborator

Add reduce via by cell size

@github-actions github-actions bot added testing Anything related to testing grpc-transition Changes that need to be included in gRPC transition labels Aug 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.55%. Comparing base (dc50f2d) to head (971fc1a).

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
+ Coverage   49.17%   49.55%   +0.38%     
==========================================
  Files         255      255              
  Lines       38052    38110      +58     
==========================================
+ Hits        18712    18887     +175     
+ Misses      19340    19223     -117     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boyang2022 boyang2022 changed the title Reduce via by density FEAT: reduce via by density Aug 28, 2025
@boyang2022 boyang2022 changed the title FEAT: reduce via by density FEAT: Reduce via by density Aug 28, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boyang2022 Please fix the codacy check.

@svandenb-dev Bo implemented both dotnet and grpc versions of the the method. I will approve now. Later on, we need to merge the two methods in a dotnet and grpc shared class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants