-
Notifications
You must be signed in to change notification settings - Fork 15
FEAT: Duplicate cell array #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
For more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1470 +/- ##
==========================================
+ Coverage 49.50% 49.55% +0.04%
==========================================
Files 254 255 +1
Lines 37900 38052 +152
==========================================
+ Hits 18764 18858 +94
- Misses 19136 19194 +58 🚀 New features to boost your workflow:
|
…cate-cell-array # Conflicts: # src/pyedb/grpc/database/modeler.py
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
For more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is method is only for a special use case. I don't think it fits in modeler. Please move to extension folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces functionality to duplicate cell arrays in pyedb by implementing a new create_cell_array extension that can replicate unit cells in x and y directions to form larger arrays. The implementation supports both gRPC and DotNet APIs through an adapter pattern.
- Adds comprehensive cell array duplication functionality supporting primitives, paths, vias, and components
- Implements adapter pattern to handle both gRPC and DotNet API differences
- Includes test infrastructure and fixes for polygon/path handling to support the new functionality
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/pyedb/extensions/create_cell_array.py | New module implementing cell array creation with adapter pattern for gRPC/DotNet compatibility |
tests/system/test_extensions.py | Adds test case for the new cell array creation functionality |
tests/conftest.py | Adds helper method to get unit cell test data |
src/pyedb/grpc/database/primitive/polygon.py | Fixes polygon void handling to support GrpcPolygonData objects |
src/pyedb/grpc/database/modeler.py | Enhances path creation to accept GrpcPolygonData objects |
src/pyedb/grpc/database/components.py | Fixes component creation logic for RLC components and null handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
No description provided.