Skip to content

Conversation

svandenb-dev
Copy link
Collaborator

No description provided.

@svandenb-dev svandenb-dev requested a review from Copilot August 28, 2025 16:11
Copilot

This comment was marked as outdated.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 49.39759% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.55%. Comparing base (c43278e) to head (bd6f4ee).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1470      +/-   ##
==========================================
+ Coverage   49.50%   49.55%   +0.04%     
==========================================
  Files         254      255       +1     
  Lines       37900    38052     +152     
==========================================
+ Hits        18764    18858      +94     
- Misses      19136    19194      +58     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the grpc-transition Changes that need to be included in gRPC transition label Aug 29, 2025
@github-actions github-actions bot added the testing Anything related to testing label Aug 29, 2025
@svandenb-dev svandenb-dev requested a review from Copilot August 29, 2025 12:38
Copilot

This comment was marked as outdated.

Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is method is only for a special use case. I don't think it fits in modeler. Please move to extension folder.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces functionality to duplicate cell arrays in pyedb by implementing a new create_cell_array extension that can replicate unit cells in x and y directions to form larger arrays. The implementation supports both gRPC and DotNet APIs through an adapter pattern.

  • Adds comprehensive cell array duplication functionality supporting primitives, paths, vias, and components
  • Implements adapter pattern to handle both gRPC and DotNet API differences
  • Includes test infrastructure and fixes for polygon/path handling to support the new functionality

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/pyedb/extensions/create_cell_array.py New module implementing cell array creation with adapter pattern for gRPC/DotNet compatibility
tests/system/test_extensions.py Adds test case for the new cell array creation functionality
tests/conftest.py Adds helper method to get unit cell test data
src/pyedb/grpc/database/primitive/polygon.py Fixes polygon void handling to support GrpcPolygonData objects
src/pyedb/grpc/database/modeler.py Enhances path creation to accept GrpcPolygonData objects
src/pyedb/grpc/database/components.py Fixes component creation logic for RLC components and null handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants