Skip to content

Conversation

svandenb-dev
Copy link
Collaborator

This PR is adding grpc cicd

@svandenb-dev svandenb-dev requested a review from Copilot August 29, 2025 15:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds gRPC support to the CI/CD pipeline by creating separate test jobs for both dotnet and gRPC configurations. The changes enable testing both communication protocols in parallel across Windows and Linux environments.

  • Added environment variable configuration for USE_GRPC in test configuration
  • Duplicated existing test jobs to create separate dotnet and gRPC variants
  • Modified job names to distinguish between dotnet and gRPC test runs

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/conftest.py Added USE_GRPC environment variable handling for test configuration
.github/workflows/ci_cd.yml Duplicated test jobs to support both dotnet and gRPC testing workflows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to testing ci/cd labels Aug 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.52%. Comparing base (2f842b5) to head (de50a82).
⚠️ Report is 4 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1473      +/-   ##
==========================================
- Coverage   49.56%   49.52%   -0.04%     
==========================================
  Files         255      255              
  Lines       38054    38095      +41     
==========================================
+ Hits        18860    18868       +8     
- Misses      19194    19227      +33     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hui-zhou-a
hui-zhou-a previously approved these changes Sep 1, 2025
Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is a good idea to skip any test for grpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd maintenance Package and maintenance related testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants