chore: Extract allowed values #4342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpohekar
requested review from
mkundu1,
seanpearsonuk and
prmukherj
as code owners
|
@hpohekar Please can we have description text: images won't play well in the logs. |
seanpearsonuk
approved these changes
Aug 6, 2025
@seanpearsonuk Done. Thank you. |
prmukherj
approved these changes
Aug 6, 2025
|
@hpohekar, for these things we can add a small test in test_codegen? |
@prmukherj Yes, we can. Will add one. |
|
We need to wait for some more time as Fluent side changes are not available in the latest Fluent image. (Tests are failing due to this). |
mkundu1
reviewed
Aug 8, 2025
mkundu1
reviewed
Aug 8, 2025
seanpearsonuk
approved these changes
Aug 12, 2025
hpohekar
added a commit
that referenced
this pull request
Sep 2, 2025
This pull request focuses on improving maintainability by extracting and explicitly defining allowed values for settings classes. The main change ensures that allowed values are clearly listed and type-annotated, which will help with code clarity and future maintenance. Settings class allowed values extraction: * Added the `_allowed_values` attribute to settings classes in both implementation and stub files, making allowed values explicit and type-annotated (`src/ansys/fluent/core/codegen/settingsgen.py`). * Documented the extraction of allowed values in the changelog (`doc/changelog.d/4342.maintenance.md`). --------- Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving maintainability by extracting and explicitly defining allowed values for settings classes. The main change ensures that allowed values are clearly listed and type-annotated, which will help with code clarity and future maintenance.
Settings class allowed values extraction:
_allowed_valuesattribute to settings classes in both implementation and stub files, making allowed values explicit and type-annotated (src/ansys/fluent/core/codegen/settingsgen.py).doc/changelog.d/4342.maintenance.md).