ci: Use the certificate generation steps from the dev guide #4691
+60
−543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
hpohekar,
mayankansys and
prmukherj
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces a Python-based certificate generation script with shell commands from the development guide. The change simplifies the build process by using standard OpenSSL commands instead of maintaining a custom Python solution with external dependencies.
Key changes:
- Removed the 539-line Python certificate generation script
- Added a shell script using OpenSSL commands for certificate generation
- Removed cryptography package dependency from the build process
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/generate_certs.py | Deleted the entire Python certificate generation implementation |
| Makefile | Updated to use new shell script and removed cryptography dependency installation |
| .ci/generate_certs.sh | New shell script implementing certificate generation using OpenSSL commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seanpearsonuk
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the certificate generation steps from the dev guide and remove the Python script.