-
-
Notifications
You must be signed in to change notification settings - Fork 921
Featrue sender max length #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature
Are you sure you want to change the base?
Featrue sender max length #1381
Conversation
…to feature_markdown
…to feature_markdown
…to feature_markdown
* feat: add openLinksInNewTab & docs change & xss * fix: fix CR * fix: fix CR * fix: fix CR * feat: xmarkdown default less * feat: default less * feat: theme * docs: add custom components * feat: theme * feat: theme * feat: add theme * feat: antd * fix: fix test case * test: less --------- Co-authored-by: jinyang <[email protected]> Co-authored-by: Mickey <[email protected]>
* feat(use-x-chat): add updating status * test(use-x-chat): fix test error about on-update callback * docs(use-x-chat): add loading for stream demo * fix(use-x-chat): always set loadingMsg when init * fix(use-x-chat): set placeholderMsg default value to empty string * test(use-x-chat): fix check filed for case about loading placeholder msg --------- Co-authored-by: Mickey <[email protected]>
…not be displayed when collapsible is enabled (ant-design#1172) * fix(thought-chain): 修改title的结构 * fix(thought-chain): 修改title部分结构,满足传递ReactNode * chore: update snapShot * update docs case * update docs case * update checkTextOverflow * chore: update snapShot * fix: replace span with div and update snapShot
* chore: changelog of 1.6.1 * chore: changelog of 1.6.1 * chore: changelog of 1.6.1
chore: next merge main
…esign#1178) * chore: changelog of 2.0.0-alpha.7 * chore: update * docs: 更新antdx文档 * docs: 更新changelog文档位置 * docs: 更新changelog文档位置 * feat: site * feat: markdown Semantic * chore: version * chore: changelog of alpha7 * fix: markdown * fix: lint * fix: lint * fix:dekkp * fix:dekkp
docs: updae docs demo
Signed-off-by: afc163 <[email protected]>
chore: next merge main
chore: Merge antdx v2 next branch into main
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1333) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: changelog 2.0.0 * chore: changelog 2.0.0
* feat: site * feat: site * feat: site
* feat: site * feat: site * feat: site * feat: site * feat: site
* feat: site * feat: site * feat: site * feat: site * feat: site * feat: site
* feat: site * feat: site * feat: site * feat: site * feat: site * feat: site * feat: site * feat: site * feat: site * feat: site
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @danjianyishangshou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求主要引入了对 Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
你好,感谢你的贡献。这个 Pull Request 的标题是“Featrue sender max length”,但实际内容是一次大规模的 Monorepo 结构重构,涉及了项目配置、文档和文件结构的巨大变更。这导致 PR 的范围过大,且与标题和描述严重不符。
为了保证代码库的可维护性和审查效率,我强烈建议:
- 拆分 PR:将 Monorepo 重构和
maxLength功能的实现拆分成两个独立的 PR。 - 更新标题和描述:如果无法拆分,请将此 PR 的标题和描述修改为能准确反映其内容(例如,“Refactor: 迁移到 Monorepo 结构”)。
由于本次变更范围极广,我的审查主要集中在一些明显的文档链接错误和文本一致性问题上。对于更小的、目标明确的 PR,我们可以进行更深入和全面的审查。下面是一些具体的反馈,请查阅。
Signed-off-by: danJ <[email protected]>
Signed-off-by: danJ <[email protected]>
Bundle ReportChanges will decrease total bundle size by 1.35MB (-31.6%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: x-markdown-array-pushAssets Changed:
|

中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log
变更摘要
新增: SlotTextArea 支持 maxLength 属性限制输入长度
修复: 超出长度时不再重置内容或丢失光标位置
优化: 粘贴和插入操作自动适配长度限制
兼容: 与现有slot配置无缝协作