Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LuaLexerBase; #4214

Merged
merged 1 commit into from
Nov 10, 2024
Merged

fix LuaLexerBase; #4214

merged 1 commit into from
Nov 10, 2024

Conversation

niu2x
Copy link
Contributor

@niu2x niu2x commented Aug 20, 2024

'\n' ascii is 10, instead of 12

@teverett teverett added the lua label Aug 25, 2024
@kaby76
Copy link
Contributor

kaby76 commented Aug 26, 2024

@teverett This PR corrects a bug in the lua grammar. I think there was a timeout issue for the Dart target. So, maybe the build can be tried again?

@kaby76
Copy link
Contributor

kaby76 commented Oct 2, 2024

@niu2x Please synch with the latest in master. Hopefully, the build will work fine. Ty.

@teverett
Copy link
Member

@niu2x please rebase

@kaby76
Copy link
Contributor

kaby76 commented Oct 24, 2024

@niu2x please rebase

@teverett I can create a PR next week for this if it's not updated by then.

'\n' assci is 10, instead of 12
@niu2x
Copy link
Contributor Author

niu2x commented Oct 28, 2024

@teverett @kaby76

yes, done

@kaby76
Copy link
Contributor

kaby76 commented Nov 4, 2024

@teverett We need a build of this PR. Ty.

@teverett
Copy link
Member

@niu2x thanks!

@teverett teverett merged commit 9726edb into antlr:master Nov 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants