Skip to content

[ai] Update Claude settings and info.#4831

Merged
teverett merged 2 commits intoantlr:masterfrom
kaby76:g4-update-claude.md-on-mvn-test
May 2, 2026
Merged

[ai] Update Claude settings and info.#4831
teverett merged 2 commits intoantlr:masterfrom
kaby76:g4-update-claude.md-on-mvn-test

Conversation

@kaby76
Copy link
Copy Markdown
Contributor

@kaby76 kaby76 commented Apr 30, 2026

  • Update CLAUDE.md with info on Maven testing.
  • Remove .claude/ directories.
  • Update the _scripts/maven.sh file to not create a .jar. Just to clean/test.

@kaby76 kaby76 marked this pull request as ready for review April 30, 2026 14:21
Copilot AI review requested due to automatic review settings April 30, 2026 14:21
@kaby76 kaby76 marked this pull request as draft April 30, 2026 14:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository contributor guidance for Maven-based grammar testing and removes committed Claude local permission settings.

Changes:

  • Document Maven (antlr4test-maven-plugin) testing workflows in CLAUDE.md, including common failure modes.
  • Remove committed settings.local.json files under various .claude/ directories (local-only permissions).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
CLAUDE.md Adds Maven testing instructions and troubleshooting notes.
.claude/settings.local.json Removes repo-root Claude local permissions file.
golang/.claude/settings.local.json Removes Claude local permissions file for golang/.
csharp/v8-spec/tooling/.claude/settings.local.json Removes Claude local permissions file for tooling.
csharp/v8-spec/testing/.claude/settings.local.json Removes Claude local permissions file for testing.
csharp/v7/.claude/settings.local.json Removes Claude local permissions file for csharp/v7/.
c/.claude/settings.local.json Removes Claude local permissions file for c/.
ada/.claude/settings.local.json Removes Claude local permissions file for ada/.
ada/ada2012/.claude/settings.local.json Removes Claude local permissions file for ada/ada2012/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CLAUDE.md
Comment thread CLAUDE.md Outdated
- Replace `mvn -B package` with `mvn -B clean test` in _scripts/maven.sh
  so the script runs the documented Maven goal instead of the package phase.
- Replace `git clean -f .` advice in CLAUDE.md with a targeted
  `find examples/ -name "*.errors" -size 0 -delete` command that only
  removes zero-length .errors files, avoiding accidental loss of untracked
  test inputs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@kaby76 kaby76 marked this pull request as ready for review April 30, 2026 20:32
@teverett
Copy link
Copy Markdown
Member

teverett commented May 2, 2026

@kaby76 thanks

@teverett teverett merged commit 39684fc into antlr:master May 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants