Skip to content

Fix/brush submit - #7305

Merged
moayuisuda merged 7 commits into
v5from
fix/brush-submit
Apr 30, 2026
Merged

Fix/brush submit#7305
moayuisuda merged 7 commits into
v5from
fix/brush-submit

Conversation

@moayuisuda

@moayuisuda moayuisuda commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator
Checklist
  • npm test passes
Description of change
image 修复类似上面这种，highlight 会将相邻 element 一起触发的bug

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the brushFilter interaction to support charts with dual Y-axes by conditionally applying the Y-axis domain based on the presence of independent scales. It also refines the intersect utility in brushHighlight to use strict inequalities, ensuring that tangent boundaries do not trigger incorrect selections of adjacent elements. I have no feedback to provide as there were no review comments to evaluate.

@moayuisuda
moayuisuda merged commit 0e01d0b into v5 Apr 30, 2026
3 of 4 checks passed
@moayuisuda
moayuisuda deleted the fix/brush-submit branch April 30, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@moayuisuda