Draft
Conversation
Author
|
Hey @AshwinSekar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VAT filtering currently is being calculated independently inside
compute_new_epoch_caches_and_rewardsandupdate_epoch_stakeswhile nothing enforcing them to be same.Summary of Changes
compute_new_epoch_caches_and_rewards, and store it onNewEpochBundleupdate_epoch_stakes, soepoch_stakesis built from the same distribution set used for rewards.get_top_epoch_stakesto accept an optional precomputed filtered VoteAccounts, avoiding recomputation and keeping the epoch-boundary path consistent.Stakes::clone_and_filter_for_vat(inruntime/src/stakes.rs) to accept the already-filtered VoteAccounts when available, so epoch-stakes construction can reuse it directly.Additional changes
As suggested in the original issue, here few more refactoring in the code:
runtime/src/bank/partitioned_epoch_rewards/calculation.rs, change the code to calculate filtered vote account len from:Bank::minimum_vote_account_balance_for_vat()for minimum balance calculation for vatCloses #11645