gossip: Remove deprecated types from tests#11995
Open
efagerho wants to merge 1 commit intoanza-xyz:masterfrom
Open
gossip: Remove deprecated types from tests#11995efagerho wants to merge 1 commit intoanza-xyz:masterfrom
efagerho wants to merge 1 commit intoanza-xyz:masterfrom
Conversation
efagerho
force-pushed
the
remove_legacy_msgs_from_tests
branch
from
3df04f7 to
6893ad2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11995 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 859 859
Lines 321697 321703 +6
=======================================
+ Hits 267851 267872 +21
+ Misses 53846 53831 -15 🚀 New features to boost your workflow:
|
gregcusack
reviewed
Apr 17, 2026
Comment on lines
339
to
363
| #[test] | ||
| fn test_max_accounts_hashes_with_push_messages() { | ||
| let mut rng = rand::rng(); | ||
| for _ in 0..256 { | ||
| let accounts_hash = AccountsHashes::new_rand(&mut rng, None); | ||
| let crds_value = | ||
| CrdsValue::new(CrdsData::AccountsHashes(accounts_hash), &Keypair::new()); | ||
| let message = Protocol::PushMessage(Pubkey::new_unique(), vec![crds_value]); | ||
| let socket = new_rand_socket_addr(&mut rng); | ||
| assert!(Packet::from_data(Some(&socket), message).is_ok()); | ||
| } | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_max_accounts_hashes_with_pull_responses() { | ||
| let mut rng = rand::rng(); | ||
| for _ in 0..256 { | ||
| let accounts_hash = AccountsHashes::new_rand(&mut rng, None); | ||
| let crds_value = | ||
| CrdsValue::new(CrdsData::AccountsHashes(accounts_hash), &Keypair::new()); | ||
| let response = Protocol::PullResponse(Pubkey::new_unique(), vec![crds_value]); | ||
| let socket = new_rand_socket_addr(&mut rng); | ||
| assert!(Packet::from_data(Some(&socket), response).is_ok()); | ||
| } | ||
| } |
There was a problem hiding this comment.
should we be getting rid of these as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently some of our deprecated types are used in non-serialization tests.
Summary of Changes
Remove deprecated types from tests to simplify removal of said types.