feat(snapshots): enable direct io for snapshot and archive creation#12015
Draft
kskalski wants to merge 4 commits intoanza-xyz:masterfrom
Draft
feat(snapshots): enable direct io for snapshot and archive creation#12015kskalski wants to merge 4 commits intoanza-xyz:masterfrom
kskalski wants to merge 4 commits intoanza-xyz:masterfrom
Conversation
`large_file_buf_writer` previously created its own `IoSetupState::default()` internally, making it impossible for callers to influence I/O configuration. Expose the parameter so callers can pass their own setup. All existing callers pass `&IoSetupState::default()` to preserve current behavior.
Move `use_registered_io_uring_buffers` and `snapshots_use_direct_io` from `AccountsDbConfig` into `SnapshotConfig` (renamed to `use_direct_io`), where they semantically belong. Thread `&SnapshotConfig` through `verify_and_unarchive_snapshots`, `bank_from_snapshot_archives`, and `bank_from_latest_snapshot_archives` so the unarchive path can construct `IoSetupState` from snapshot config flags. Archive writer uses default `IoSetupState` for now.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #12015 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 859 859
Lines 321697 321698 +1
=======================================
+ Hits 267851 267887 +36
+ Misses 53846 53811 -35 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #12014
Problem
Summary of Changes
Fixes #