v3.1: blockstore: Add fallback in mark_slot_dead_if_not_full() (backport of #12026)#12027
Open
mergify[bot] wants to merge 2 commits intov3.1from
Open
v3.1: blockstore: Add fallback in mark_slot_dead_if_not_full() (backport of #12026)#12027mergify[bot] wants to merge 2 commits intov3.1from
mergify[bot] wants to merge 2 commits intov3.1from
Conversation
This method currently only checks the ShredInsertionTracker for a slot meta; fallback to the blockstore as an extra check if we don't find a meta in the tracker (cherry picked from commit 9808d65) # Conflicts: # ledger/src/blockstore.rs
Author
|
Cherry-pick of 9808d65 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
BlockLocation doesn't exists in v3.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This method currently only checks the ShredInsertionTracker for a slot meta.
Summary of Changes
Fallback to the blockstore as an extra check if we don't find a meta in the tracker + add unit test
This is an automatic backport of pull request #12026 done by Mergify.