Skip to content

deprecate BlockProductionMethod::CentralScheduler#12033

Open
apfitzge wants to merge 1 commit intoanza-xyz:masterfrom
apfitzge:remove_prio_graph_scheduler_deprecate
Open

deprecate BlockProductionMethod::CentralScheduler#12033
apfitzge wants to merge 1 commit intoanza-xyz:masterfrom
apfitzge:remove_prio_graph_scheduler_deprecate

Conversation

@apfitzge
Copy link
Copy Markdown

Problem

Summary of Changes

  • Add deprecation warnings for uses of central-scheduler

Fixes #

@apfitzge apfitzge force-pushed the remove_prio_graph_scheduler_deprecate branch from 19ec870 to c1153d2 Compare April 17, 2026 21:16
BlockProductionMethod
)
.unwrap_or_default();
block_production_method.warn_if_deprecated();
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not hit it here in the original PR

@apfitzge apfitzge requested a review from steviez April 17, 2026 21:17
@apfitzge apfitzge added the v4.0 Backport to v4.0 branch label Apr 17, 2026
@mergify
Copy link
Copy Markdown

mergify bot commented Apr 17, 2026

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (b9aa405) to head (c1153d2).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #12033     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         861      861             
  Lines      322317   322327     +10     
=========================================
- Hits       268489   268467     -22     
- Misses      53828    53860     +32     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4.0 Backport to v4.0 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants