ARTEMIS-4568 Configuration reload for AMQP federation broker connections #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabish121
force-pushed
the
broker-connector-reload
branch
from
d84d6b9 to
2de2eb2
Compare
gemmellr
reviewed
Jan 18, 2024
.../apache/activemq/artemis/core/config/amqpBrokerConnectivity/AMQPBrokerConnectionElement.java
Outdated
Show resolved
Hide resolved
...che/activemq/artemis/core/config/amqpBrokerConnectivity/AMQPBrokerConnectionElementTest.java
Outdated
Show resolved
Hide resolved
|
LGTM. Give the commits a squash. |
Allows the configuration of AMQP Federation broker connections to be updated and reloaded. This allows for update, add or remove of AMQP federation broker connections as well as the basic AMQP sender and receiver broker connections. It checks for and ignores changes in AMQP broker connections that are performing Mirroring as that would lead to issues that can break mirroring.
tabish121
force-pushed
the
broker-connector-reload
branch
from
80afdea to
12492f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the configuration of AMQP Federation broker connections to be updated and reloaded. This allows for update, add or remove of AMQP federation broker connections as well as the basic AMQP sender and receiver broker connections. It checks for and ignores changes in AMQP broker connections that are performing Mirroring as that would lead to issues that can break mirroring.