ARTEMIS-4569 Blocked Producers will hold runnables until messages are… #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
force-pushed
the
page-block
branch
12 times, most recently
from
94db8c2 to
903054f
Compare
tabish121
reviewed
Jan 17, 2024
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/runnables/RunnableList.java
Outdated
Show resolved
Hide resolved
clebertsuconic
force-pushed
the
page-block
branch
from
903054f to
741242b
Compare
clebertsuconic
commented
Jan 17, 2024
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/runnables/RunnableList.java
Outdated
Show resolved
Hide resolved
clebertsuconic
force-pushed
the
page-block
branch
from
741242b to
4b75e39
Compare
clebertsuconic
commented
Jan 17, 2024
...leak-tests/src/test/java/org/apache/activemq/artemis/tests/leak/ProducerBlockedLeakTest.java
Outdated
Show resolved
Hide resolved
clebertsuconic
force-pushed
the
page-block
branch
2 times, most recently
from
9661372 to
1d01ba6
Compare
… consumed. When initially developed the expectation was that no more producers would keep connecting but in a scenario like this the consumers could actually give up and things will just accumulate on the server. We should cleanup these upon disconnect.
clebertsuconic
force-pushed
the
page-block
branch
from
1d01ba6 to
a5de1f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… consumed.
When initially developed the expectation was that no more producers would keep connecting but in a scenario like this the consumers could actually give up and things will just accumulate on the server.
We should cleanup these upon disconnect.