ARTEMIS-4752 upgrade ErrorProne to 2.27.0 #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgraded ErrorProne found some new issues so this commit fixes those as well.
|
@gemmellr, I don't meant to step on your toes with your work on the JUnit 5 upgrade, but these test changes were necessary for the upgrade. If necessary we can certainly wait until your done if you prefer. |
|
I only asked not to merge the other one and have me roll related changes into my work since it was quite big but wasnt actually 'fixing' anything that was 'broken', so it would have been annoying to deal with the conflicts given that...this is fixing stuff, so it goes in and I deal with it along with the other rebase stuff needed. (Happily its also smaller). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.